Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile: Accessibility: Improve screen reader accessibility of the tag list #11420

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Mobile: Accessibility: Improve screen reader accessibility of the tag list #11420

merged 1 commit into from
Nov 20, 2024

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Nov 20, 2024 •
edited
Loading

Summary

This pull request:

  1. Migrates tags.js (the tags list screen) to TypeScript.
  2. Adds role and hint information to tag items.

Related to #10795.

Testing plan

Android (API 35, emulator):

  1. Create at least one tag.
  2. With TalkBack enabled, open the tags list.
  3. Move TalkBack focus to the first tag.
    • For me, this tag has title "tag1".
  4. Verify that TalkBack reads "tag1. Button. Shows notes for tag."
  5. Double-tap the screen.
  6. Verify that the notes associated with the tag are visible.

iOS 18 (simulator):

  1. Ensure that there is at least one tag.
  2. With VoiceOver enabled, open the tag list.
  3. Move focus to the first item in the list.
  4. Verify that VoiceOver reads "tagname. Button." then "Shows notes for tag, You are currently on a button."

@personalizedrefrigerator
Mobile: Accessibility: Improve tags screen accessibility
9a57815 
This commit:
1. Migrates tags.js to TypeScript.
2. Adds role and hint information to tag items.

Note: See https://github.com/formidablelabs/eslint-plugin-react-native-a11y/blob/master/docs/rules/has-accessibility-hint.md for examples of how to use accessibilityHint.
@personalizedrefrigerator personalizedrefrigerator changed the title Mobile: Accessibility: Improve tags screen accessibility Mobile: Accessibility: Improve tags screen screen reader accessibility Nov 20, 2024
@personalizedrefrigerator personalizedrefrigerator changed the title Mobile: Accessibility: Improve tags screen screen reader accessibility Mobile: Accessibility: Improve screen reader accessibility of tags list Nov 20, 2024
@personalizedrefrigerator personalizedrefrigerator added the accessibility Related to accessibility label Nov 20, 2024
@personalizedrefrigerator personalizedrefrigerator changed the title Mobile: Accessibility: Improve screen reader accessibility of tags list Mobile: Accessibility: Improve screen reader accessibility of tag list Nov 20, 2024
@personalizedrefrigerator personalizedrefrigerator changed the title Mobile: Accessibility: Improve screen reader accessibility of tag list Mobile: Accessibility: Improve screen reader accessibility of the tag list Nov 20, 2024
@laurent22 laurent22 merged commit c9608cf into laurent22:dev Nov 20, 2024
7 checks passed
@personalizedrefrigerator personalizedrefrigerator mentioned this pull request Nov 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
accessibility Related to accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@personalizedrefrigerator @laurent22